Code review of the microprofile crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.2.1 (current) Rating: Negative Thoroughness: Low Understanding: Low

by MaulingMonkey on 2020-01-09

https://github.com/MaulingMonkey/rust-reviews/blob/master/reviews/microprofile.md#021 Decent seeming crate, but 98% underdocumented underfuzzed C++ that is network exposed, parses strings, rewrites x86, etc. Might use for development but using it in production would just be begging for CVEs.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open microprofile. Alternatively, you can download the tarball of microprofile v0.2.1 or view the source online.