Code reviews of the Termios crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.3.3 (current) Rating: Positive Thoroughness: Low Understanding: High

by MaulingMonkey on 2021-08-24

[Full Audit] Terminal I/O Settings

Pros:

Portable as heck
Probably sound

Cons:

Limited tests
No verification against native C headers

Audit

⚠️ Didn't verify many OS-specific structs/constants, and termios structure might not guarantee ABI stability?

The current version of Termios is 0.3.3.

0.3.2 (older version) Rating: Positive Thoroughness: Low Understanding: High

by MaulingMonkey on 2021-08-24

Show review…

[Full Audit] Terminal I/O Settings

Pros:

Portable as heck
Probably sound

Cons:

Limited tests
No verification against native C headers

Audit

⚠️ Didn't verify many OS-specific structs/constants, and termios structure might not guarantee ABI stability?

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

0.3.3 (current) safe-to-run

From kornelski/crev-proofs copy of salsa.debian.org.

Packaged for Debian (stable). Changelog:

Team upload.
Package termios 0.3.3 from crates.io using debcargo 2.4.4

0.3.3 (current) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

The current version of Termios is 0.3.3.

0.2.2 (older version) safe-to-run, does-not-implement-crypto

From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe

Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open termios. Alternatively, you can download the tarball of termios v0.3.3 or view the source online.