Code reviews of the Tap crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

1.0.1 (current) Rating: Positive Thoroughness: Medium Understanding: Medium

by Minoru on 2021-03-24

Delta since 1.0.0 only shows rustdoc improvements: module documentation is hoisted into the root of the crate.

My review of 1.0.0 stands.

The current version of Tap is 1.0.1.

1.0.0 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by Minoru on 2021-03-11

Show review…

This crate provides three pieces of plumbing that makes it easier to chain functions:

"taps", which pass the borrowed value into a function and then return it (think logging);
"pipes", which are basically a universal map();
"conv", which is like into() but lets you specify the target type, so you can put it in the middle of a call-chain.

A lot of pretty boring code. It looks all right to me, but I got too lazy to check why functions usually require sized types; that's why I cap my "thoroughness" and "understanding" at "medium", and rating at "positive".

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

1.0.1 (current) safe-to-deploy

From EmbarkStudios/rust-ecosystem. By Embark.

No unsafe usage or ambient capabilities

1.0.1 (current) safe-to-run

From kornelski/crev-proofs copy of salsa.debian.org.

Packaged for Debian (stable). Changelog:

Package tap 1.0.1 from crates.io using debcargo 2.6.0

1.0.1 (current) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open tap. Alternatively, you can download the tarball of tap v1.0.1 or view the source online.