1.0.1 (older version) Thoroughness: Low Understanding: Medium
by kpreid on 2024-04-23
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of SyncWrapper is 1.0.2.
0.1.1 (older version) Thoroughness: Medium Understanding: High
by niklasf on 2021-10-16
Reviewed for soundness. There are two instances of unsafe code.
One is a standard pin projection.
The other is the primary purpose of the crate:
unsafe impl Sync for SyncWrapper {}
This is equivalent to the statement that all instances of &SyncWrapper can be safely sent across thread boundaries. This is true, because &SyncWrapper is useless. The crate allows no operations on &SyncWrapper alltogether. The only provided methods require &mut SyncWrapper or owned SyncWrapper.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of SyncWrapper is 1.0.2.
1.0.1 — diff review from 0.1.2 only (older version)
From zcash/rust-ecosystem copy of zcash/librustzcash. Audited without comment by str4d.
0.1.2 (older version)
From google/supply-chain copy of google/rust-crate-audits. By Taylor Cramer.
Reviewed in CL 605332043
0.1.2 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
0.1.1 (older version)
From google/supply-chain copy of chromium. Audited without comment by ChromeOS.
0.1.1 (older version)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- does-not-implement-crypto (implies crypto-safe)
-
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
- crypto-safe
Implied by other criteria
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use
does-not-implement-crypto, which impliescrypto-safe, but does not require expert review in order to audit for.- ub-risk-1 (implies ub-risk-2)
-
Excellent soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-1
- ub-risk-2 (implies ub-risk-3)
Implied by other criteria
Negligible unsoundness or average soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2
- ub-risk-3 (implies ub-risk-4)
Implied by other criteria
Mild unsoundness or suboptimal soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3
- ub-risk-4
Implied by other criteria
Extreme unsoundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- unknown
-
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open sync_wrapper. Alternatively, you can download the tarball of sync_wrapper v1.0.2 or view the source online.
Does what it says it does, and what it says it does is sound as far as I know. In fact, the standard library contains the same thing, unstable, under the name
std::sync::Exclusive: https://doc.rust-lang.org/1.77.0/std/sync/struct.Exclusive.html So this library can be seen as an interim substitute for that.