0.5.1 — diff review from 0.4.1 only (older version)
From zcash/rust-ecosystem copy of zcash/librustzcash. By Daira-Emma Hopwood.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of redox_syscall is 0.5.9.
0.5.1 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
0.3.5 — diff review from 0.2.16 only (older version)
From mozilla/supply-chain copy of mozilla/glean. Audited without comment by Jan-Erik Rediger.
0.2.16 — diff review from 0.2.13 only (older version)
From mozilla/supply-chain copy of hg. Audited without comment by Mike Hommey.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- unknown
-
May have been packaged automatically without a review
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of redox_syscall is 0.5.9.
0.1.56 (older version) Thoroughness: Low Understanding: Low
by MaulingMonkey on 2019-07-24
Exposes unsound APIs, lots of unverified syscalls.
Reviewed:
src\arch*.rs: Skimmed... looks reasonable, but didn't verify correct instructions / register invalidation.
src\io\dma.rs: Some unsafe... looks correct, but not thoroughly tested.
src\io\io.rs: +1
src\io\mmio.rs: UNSOUND (can construct uninitialized() T via "safe" Mmio::new()!)
src\io\mod.rs: +1
src\io\pio.rs: Some unsafe... looks reasonable, but didn't verify correct instructions.
src\scheme\generate.sh: +1
src\scheme\mod.rs: +1
src\scheme\scheme*.rs: UNSOUND (can construct arbitrary slices from arbitrary Packet s via Scheme*::handle)
.cargo_vcs_info.json: +1 .cargo-ok: +1 .gitlab-ci.yml: +1 Cargo.toml: +1 Cargo.toml.orig: +1 LICENSE: +1 README.md: +1
Skimmed:
src\call.rs: Lots of unsafe syscalls... unverified. src\data.rs: UNSOUND (Map deref etc.) src\error.rs: No tests for STR_ERROR, but at least it's sound. src\flag.rs: Sound, magic constant city, meh. src\lib.rs: LEAKS UNSOUND TRAITS into public interface! src\number.rs: Safe, magic constant city. src\tests.rs: Unsafe, but only #[test]s
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open redox_syscall. Alternatively, you can download the tarball of redox_syscall v0.5.9 or view the source online.
Uses of unsafe look plausible.