0.3.0 (current) Thoroughness: Medium Understanding: Medium
by ThomasdenH on 2021-12-23
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
0.3.0 (current) Thoroughness: High Understanding: Medium
by Minoru on 2021-04-28
This implements a xorshift RNG with 128 bits of state.
The implementation uses no unsafe, and does not even require std. The code is straightforward, and matches the code from the paper that describes the RNG ("Xorshift RNGs" by George Marsaglia).
Seeding from an existing RNG can theoretically hang if the seeding RNG keeps returning zeroes. I filed https://github.com/rust-random/rngs/issues/24 about this and capped the rating at "positive".
The current version of rand_xorshift is 0.3.0.
0.1.1 (older version) Thoroughness: Medium Understanding: Medium
by git.sr.ht/~icefox on 2019-08-20
Uses a semi-unnecessary unsafe for speed, which I dislike, but is overall harmless.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
0.3.0 (current)
From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by ebfull.
0.3.0 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
The current version of rand_xorshift is 0.3.0.
0.2.0 (older version)
From google/supply-chain copy of google/rust-crate-audits. By Augie Fackler.
Reviewed in CL 615005895
0.1.1 (older version)
From google/supply-chain copy of chromium. By George Burgess IV.
The rand_xorshift algorithm is not intended to be cryptographically secure in
any real sense, so does-not-implement-crypto is selected here.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- does-not-implement-crypto (implies crypto-safe)
-
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
- crypto-safe
Implied by other criteria
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use
does-not-implement-crypto, which impliescrypto-safe, but does not require expert review in order to audit for.- ub-risk-2 (implies ub-risk-3)
-
Negligible unsoundness or average soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2
- ub-risk-3 (implies ub-risk-4)
Implied by other criteria
Mild unsoundness or suboptimal soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3
- ub-risk-4
Implied by other criteria
Extreme unsoundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4
- unknown
-
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open rand_xorshift. Alternatively, you can download the tarball of rand_xorshift v0.3.0 or view the source online.
This is a very small crate. The RNG doesn't make any security guarantees, which makes the risks associated with the crate low. The code seems to implement the algorithm from the paper straightforwardly, although it doesn't specify why the particular values for a, b, c were chosen. (They don't seem to appear in the paper)