4.3.3 (current) Thoroughness: Low Understanding: Low
by kornelski on 2023-10-12
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
4.3.3 (current) Thoroughness: Low Understanding: Low
by kornelski on 2023-10-12
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open ffmpeg-sys
. Alternatively, you can download the tarball of ffmpeg-sys v4.3.3 or view the source online.
This crate has very sporadic and unreliable maintenance. Additionally, the sister
ffmpeg
crate is broken almost all of the time, because these crates generate working bindings valid for only a single very specific version of ffmpeg installed in the system, and cause compile breakage if your ffmpeg is any newer or older. You should useffmpeg-next
/ffmpeg-sys-next
crates, even though they're not very actively maintained either.