Code reviews of the Bsdiff crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Bsdiff is 0.2.1.

0.1.5 (older version) Rating: Positive Thoroughness: High Understanding: Medium

by kornelski on 2021-08-01

Now 100% safe code

0.1.3 (older version) Rating: Neutral Thoroughness: Low Understanding: Medium

by kornelski on 2021-07-28

Show review…

Diffing code looks like automatically converted C code, with none of Rust safety. Patching is fine — in Rust.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open bsdiff. Alternatively, you can download the tarball of bsdiff v0.2.1 or view the source online.