Code reviews of the ASE crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.3 (current) Rating: Neutral Thoroughness: Medium Understanding: Medium

by MaulingMonkey on 2020-03-19

Not suitable for UGC - memory exhaustion and panic concerns. https://github.com/MaulingMonkey/rust-reviews/blob/master/reviews/ase.md#0.1.3

The current version of ASE is 0.1.3.

0.1.1 (older version) Rating: Neutral Thoroughness: Medium Understanding: Medium

by MaulingMonkey on 2020-03-19

Show review…

Not suitable for UGC - memory exhaustion and panic concerns. https://github.com/MaulingMonkey/rust-reviews/blob/master/reviews/ase.md#0.1.1

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open ase. Alternatively, you can download the tarball of ase v0.1.3 or view the source online.