Code reviews of the arrayref crate // Lib.rs

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

0.3.9 — diff review from 0.3.8 only (current) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. By str4d.

Changes to unsafe lines are to make some existing unsafe fns const.

0.3.9 — diff review from 0.3.7 only (current) ub-risk-2

From google/supply-chain copy of google/rust-crate-audits. By Manish Goregaokar.

Reviewed in CL 693504716 Diff fixes https://github.com/droundy/arrayref/issues/26

The current version of arrayref is 0.3.9.

0.3.8 — diff review from 0.3.6 only (older version) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by Daira Emma Hopwood.

0.3.7 — diff review from 0.3.6 only (older version) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by ebfull.

0.3.7 (older version) ub-risk-3

From google/supply-chain copy of google/rust-crate-audits. By Luca Versari, Manish Goregaokar.

Reviewed in CL 636647431 Issues found:

Macros do not overflow check before adding pre/post and can cause hard-to-trigger UB. https://github.com/droundy/arrayref/issues/26

0.3.7 (older version) unknown

From kornelski/crev-proofs copy of salsa.debian.org.

Only in debcargo (unstable). Changelog:

Team upload.
Package arrayref 0.3.7 from crates.io using debcargo 2.6.1

0.3.6 (older version) safe-to-deploy

From bytecodealliance/wasmtime. By Nick Fitzgerald.

Unsafe code, but its logic looks good to me. Necessary given what it is doing. Well tested, has quickchecks.

0.3.6 (older version) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

Implied by other criteria

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

ub-risk-3 (implies ub-risk-4)

Mild unsoundness or suboptimal soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3

ub-risk-4

Implied by other criteria

Extreme unsoundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4

ub-risk-2 (implies ub-risk-3)

Negligible unsoundness or average soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2

unknown

May have been packaged automatically without a review

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of arrayref is 0.3.9.

0.3.5 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

Approved without comment by kornelski on 2019-10-11

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open arrayref. Alternatively, you can download the tarball of arrayref v0.3.9 or view the source online.